feat(account): support importing hmcl accounts #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Xun_Ying <[email protected]>
UNIkeEN
changed the title
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements account import functionality from other Minecraft launchers (specifically HMCL). It's marked as WIP (Work in Progress) and adds a two-stage import process: retrieving account information from external launchers, then importing selected accounts and auth servers into SJMCL.
Changes:
- Added new
ImportLauncherTypeenum and two new account service methods for importing external account data - Created
ImportAccountInfoModalcomponent with UI for selecting accounts and auth servers to import - Implemented HMCL account parsing logic in Rust, supporting offline, Microsoft, and third-party accounts
- Added comprehensive localization support for import functionality in English and Chinese
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/account.ts | Added two new service methods for retrieving and importing external launcher account info |
| src/pages/accounts.tsx | Integrated import modal into accounts page UI |
| src/components/modals/import-account-info-modal.tsx | New modal component for account import workflow |
| src/enums/account.ts | Added ImportLauncherType enum for supported launchers |
| src/components/common/selectable-card.tsx | Removed conditional margin styling |
| src/locales/*.json | Added translations for import functionality and moved generic "import" button text |
| src-tauri/src/lib.rs | Registered two new Tauri commands for account import |
| src-tauri/src/account/models.rs | Refactored Player::from to support custom auth server lists |
| src-tauri/src/account/helpers/import/*.rs | New import module with HMCL parser implementation |
| src-tauri/src/account/commands.rs | Implemented retrieve and import commands for external accounts |
| src-tauri/src/account/helpers/authlib_injector/*.rs | Refactored to support empty texture properties |
| public/images/icons/external/*.png | Added launcher icons for SCL and PCL |
UNIkeEN
changed the title
Reqwey
approved these changes
Jan 17, 2026
Nova-Squ1
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR is a ..
Related Issues
close #1226
Description
Additional Context